Restructured ACLControlBox5 into multiple modules#182
Merged
Conversation
Is now split into AccessController, AccessGroups, and AddAgentButtons. Have also added JSS to showcase how dynamic CSS can work. (Is not much work to remove if not wanted.)
megoth
changed the title
timbl
requested changes
Jan 9, 2020
Contributor
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Suggest change function names
timbl
approved these changes
Jan 10, 2020
TallTed
reviewed
Jan 10, 2020
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is now split into AccessController, AccessGroups, and AddAgentButtons. All methods that are related to DOM manipulation are prefixed
render- the rest deals with data manipulation and state handling. Further, no non-render-methods should call on anyrender-methods.This (I think) makes the code easier to read and maintain.
Have also added JSS to showcase how dynamic CSS can work. (Is not much work to remove if not wanted.)
Fixes https://github.com/solid/solid-ui/issues/121.